[libc] Fix utimes build when full_build=OFF #149668
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Same as PR llvm#149665: we might pull a header from host where tv_nsec is not a long, so compilation would fail with an implicit conversion error.
|
@llvm/pr-subscribers-libc Author: Mikhail R. Gadelha (mikhailramalho) ChangesSame as PR #149665: we might pull a header from the host where tv_nsec is not a long, so compilation would fail with an implicit conversion error. Full diff: https://github.com/llvm/llvm-project/pull/149668.diff 1 Files Affected:
diff --git a/libc/src/sys/time/linux/utimes.cpp b/libc/src/sys/time/linux/utimes.cpp
index ed37b42aedf6c..36220d73e7c19 100644
--- a/libc/src/sys/time/linux/utimes.cpp
+++ b/libc/src/sys/time/linux/utimes.cpp
@@ -59,8 +59,8 @@ LLVM_LIBC_FUNCTION(int, utimes,
ts[1].tv_sec = times[1].tv_sec;
// convert u-seconds to nanoseconds
- ts[0].tv_nsec = times[0].tv_usec * 1000;
- ts[1].tv_nsec = times[1].tv_usec * 1000;
+ ts[0].tv_nsec = static_cast<decltype(ts[0].tv_nsec)>(times[0].tv_usec * 1000);
+ ts[1].tv_nsec = static_cast<decltype(ts[1].tv_nsec)>(times[1].tv_usec * 1000);
ts_ptr = ts;
}
|
|
✅ With the latest revision this PR passed the C/C++ code formatter. |
Signed-off-by: Mikhail R. Gadelha <[email protected]>
lntue
approved these changes
Jul 19, 2025
This was referenced Jul 23, 2025
mahesh-attarde
pushed a commit
to mahesh-attarde/llvm-project
that referenced
this pull request
Jul 28, 2025
We might pull a header from the host where tv_nsec is not a long, so compilation would fail with an implicit conversion error.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Same as PR #149665: we might pull a header from the host where tv_nsec is not a long, so compilation would fail with an implicit conversion error.